Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix immediate popup on start #231

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rene-descartes2021
Copy link
Collaborator

@rene-descartes2021 rene-descartes2021 commented Dec 6, 2022

Changes:

  • Fixed problem in which_key#start(). If description dictionary is small, then even if user types fast the window will show immediately, as getchar(1) is reached quickly and is false, then window shows.
    • A problem with this fix is if the dictionary is large, then the cumulative delay could be around 2 seconds... Could be mitigated with use of reltime(), if has('reltime').
    • Related: g:which_key_timeout doesn't seem to work #158. Perhaps there could be a boolean setting added here which allows the end-user to show the popup menu immediately without delay, if they wanted.

Stuff that will be in other PRs:

  • [WIP] Fix regression in :WhichKey! {dict} form? Cache shouldn't be shared between the two forms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant